Fix release verification docs and ship .bundle signing artifact#1068
Draft
Fix release verification docs and ship .bundle signing artifact#1068
Conversation
- RELEASE.md: Correct certificate identity from release.yml@refs/tags/... to action-build.yml@refs/heads/main (matching actual OIDC behavior for reusable workflows). Replace .bundle-based instructions with .sig/.pem flags matching what is actually shipped in releases. Add step-by-step download/unpack/verify flow with explanatory note. - installation.md: Add context about signing artifacts included in tarballs, link to cosign docs, and add explanatory note about certificate identity. - sign/action.yml: Also copy .bundle file to dist/bin/ so it ships alongside .sig and .pem in release tarballs. Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update release verification instructions for wasmtime shim
Fix release verification docs and ship .bundle signing artifact
Feb 24, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes critical issues in the release verification documentation where the certificate identity was incorrect and referenced non-existent .bundle files in verification commands. Users attempting to verify releases would have failed with the old documentation.
Changes:
- Corrected the certificate identity from
release.yml@refs/tags/...toaction-build.yml@refs/heads/mainto reflect how GitHub OIDC tokens work for reusable workflows - Updated verification commands to use
.sigand.pemfiles instead of.bundlefiles, matching standard cosign patterns - Added
.bundlefiles to the release tarball by copying them todist/bin/in the sign action
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| RELEASE.md | Updated verification instructions with correct certificate identity, replaced .bundle references with .sig/.pem flags, and added comprehensive download/unpack/verify steps with explanation of why action-build.yml@refs/heads/main is the correct identity |
| docs/src/getting-started/installation.md | Updated installation verification section with correct certificate identity and .sig/.pem flags, added explanatory note about reusable workflow behavior |
| .github/actions/sign/action.yml | Added cp *.bundle dist/bin/ to include bundle files in release artifacts alongside existing .sig and .pem files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release verification instructions had wrong certificate identity (
release.yml@refs/tags/...) and referenced.bundlefiles that weren't shipped. Users couldn't verify releases.Documentation fixes
action-build.yml@refs/heads/main(GitHub OIDC tokens for reusable workflows use the called workflow's identity, not the caller's). Replaced.bundleinstructions with.sig/.pemflags matching what's actually in the tarball. Added download/unpack/verify steps.Workflow fix
.github/actions/sign/action.yml: The sign action generates.bundlefiles but never copied them todist/bin/. Addedcp *.bundle dist/bin/alongside the existing.sig/.pemcopies.Corrected verification command
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.