Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ crossbeam = "0.8.1"
futures = "0.3.19"
libc = "0.2.112"
log = {version = "0.4.2", features=["kv_unstable"]}
nix = "0.29"
nix = "0.30"
oci-spec = "0.7"
os_pipe = "1.1"
prctl = "1.0.0"
Expand Down
6 changes: 3 additions & 3 deletions crates/runc/src/asynchronous/io.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
limitations under the License.
*/

use std::{fmt::Debug, io::Result, os::unix::io::AsRawFd, process::Stdio};
use std::{fmt::Debug, io::Result, process::Stdio};

use async_trait::async_trait;
use nix::unistd::{Gid, Uid};
Expand Down Expand Up @@ -67,10 +67,10 @@ impl PipedIo {
let gid = Some(Gid::from_raw(gid));
if stdin {
let rd = pipe.rd.try_clone()?;
nix::unistd::fchown(rd.as_raw_fd(), uid, gid)?;
nix::unistd::fchown(rd, uid, gid)?;
} else {
let wr = pipe.wr.try_clone()?;
nix::unistd::fchown(wr.as_raw_fd(), uid, gid)?;
nix::unistd::fchown(wr, uid, gid)?;
}
Ok(Some(pipe))
}
Expand Down
6 changes: 3 additions & 3 deletions crates/runc/src/synchronous/io.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ use std::{
fmt::Debug,
fs::{File, OpenOptions},
io::Result,
os::unix::{fs::OpenOptionsExt, io::AsRawFd},
os::unix::fs::OpenOptionsExt,
process::Stdio,
sync::Mutex,
};
Expand Down Expand Up @@ -72,10 +72,10 @@ impl PipedIo {
let gid = Some(Gid::from_raw(gid));
if stdin {
let rd = pipe.rd.try_clone()?;
nix::unistd::fchown(rd.as_raw_fd(), uid, gid)?;
nix::unistd::fchown(rd, uid, gid)?;
} else {
let wr = pipe.wr.try_clone()?;
nix::unistd::fchown(wr.as_raw_fd(), uid, gid)?;
nix::unistd::fchown(wr, uid, gid)?;
}
Ok(Some(pipe))
}
Expand Down
6 changes: 5 additions & 1 deletion crates/shim/src/util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,12 @@ pub fn connect(address: impl AsRef<str>) -> Result<RawFd> {
// so there is a chance of leak if fork + exec happens in between of these calls.
#[cfg(not(target_os = "linux"))]
{
use std::os::fd::BorrowedFd;

use nix::fcntl::{fcntl, FcntlArg, FdFlag};
fcntl(fd, FcntlArg::F_SETFD(FdFlag::FD_CLOEXEC)).map_err(|e| {
// SAFETY: fd is a valid file descriptor that we just created
let borrowed_fd = unsafe { BorrowedFd::borrow_raw(fd) };
fcntl(borrowed_fd, FcntlArg::F_SETFD(FdFlag::FD_CLOEXEC)).map_err(|e| {
let _ = close(fd);
e
})?;
Expand Down
Loading