estargz: deprecate errorutil in favor of native errors.Join#2247
Open
thaJeztah wants to merge 1 commit intocontainerd:mainfrom
Open
estargz: deprecate errorutil in favor of native errors.Join#2247thaJeztah wants to merge 1 commit intocontainerd:mainfrom
thaJeztah wants to merge 1 commit intocontainerd:mainfrom
Conversation
thaJeztah
commented
Feb 15, 2026
|
|
||
| // Aggregate combines a list of errors into a single new error. | ||
| // | ||
| // Deprecated: use [errors.Join] instead. This package will be removed in v0.19.0 |
Member
Author
There was a problem hiding this comment.
cc @ktock I put v0.19.0 here, but can either remove that, or adjust to what makes sense.
Member
Author
|
Failure looks unrelated; ++ VERSION_ROOT=v0.15.0
++ VERSION_HELM_JOB=v0.9.14-build20260210
+++ curl -sL https://raw.githubusercontent.com/k3s-io/kubernetes/refs/tags/v1.35.1-k3s1/.go-version
++ VERSION_GOLANG=go1.25.6
++ [[ -n v1.35.0-k3s1 ]]
++ [[ ! v1.35.0-k3s1 =~ ^v1\.35\.1[+-] ]]
++ echo 'Tagged version '\''v1.35.0-k3s1'\'' does not match expected version '\''v1.35.1[+-]*'\'''
Tagged version 'v1.35.0-k3s1' does not match expected version 'v1.35.1[+-]*'
++ exit 1 |
ktock
approved these changes
Feb 16, 2026
Member
ktock
left a comment
ktock
left a comment
There was a problem hiding this comment.
Thanks, I've just fixed the CI failure, could you rebase the PR?
Commit cf6d7a0 introduced this package as a replacement for `github.com/hashicorp/go-multierror`. Now that Go stdlib provides native support for multi-errors through errors.Join, we can deprecated the utility, and use stdlib errors instead. Using errors.Join will produce a slightly different formatting, but should still capture the same information. There do not appear to be external consumers of this package, other than through vendoring, so we could decide to remove the package entirely; https://grep.app/search?f.lang=Go&q=estargz%2Ferrorutil Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
native_multierror
branch
from
72d8875 to
27f4793
Compare
Member
Author
|
Thx! Rebased 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit cf6d7a0 introduced this package as a replacement for
github.com/hashicorp/go-multierror. Now that Go stdlib provides native support for multi-errors through errors.Join, we can deprecated the utility, and use stdlib errors instead. Using errors.Join will produce a slightly different formatting, but should still capture the same information.There do not appear to be external consumers of this package, other than through vendoring, so we could decide to remove the package entirely; https://grep.app/search?f.lang=Go&q=estargz%2Ferrorutil