sync-server: Fix infinite loop caused by accept error#271
Merged
wllenyj merged 1 commit intocontainerd:masterfrom Jan 13, 2025
Merged
sync-server: Fix infinite loop caused by accept error#271wllenyj merged 1 commit intocontainerd:masterfrom
wllenyj merged 1 commit intocontainerd:masterfrom
Conversation
jsturtevant
reviewed
Jan 8, 2025
Tim-Zhang
force-pushed
the
fix-infinite-accept-loop-master
branch
2 times, most recently
from
a845820 to
47f828a
Compare
quanweiZhou
approved these changes
Jan 9, 2025
lifupan
approved these changes
Jan 9, 2025
Also Add the method set_accept_retry_interval. Since poll is level-triggered, an uncorrected error can lead to an infinite loop, so we sleep for a while and wait for the error to be corrected. Fixes: containerd#270 Signed-off-by: Tim Zhang <tim@hyper.sh>
Tim-Zhang
force-pushed
the
fix-infinite-accept-loop-master
branch
from
47f828a to
c351f0b
Compare
jsturtevant
approved these changes
Jan 10, 2025
wllenyj
approved these changes
Jan 13, 2025
Tim-Zhang
added a commit
to Tim-Zhang/ttrpc-rust
that referenced
this pull request
Jan 15, 2025
Changelog: - containerd#259 - containerd#261 - containerd#264 - containerd#267 - containerd#268 - containerd#271 Signed-off-by: Tim Zhang <tim@hyper.sh>
Merged
KarstenB
pushed a commit
to KarstenB/ttrpc-rust
that referenced
this pull request
May 1, 2025
…loop-master sync-server: Fix infinite loop caused by accept error
KarstenB
pushed a commit
to KarstenB/ttrpc-rust
that referenced
this pull request
May 1, 2025
Changelog: - containerd#259 - containerd#261 - containerd#264 - containerd#267 - containerd#268 - containerd#271 Signed-off-by: Tim Zhang <tim@hyper.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since poll is level-triggered, an uncorrected error can lead to an infinite loop, so we sleep for a while and wait for the error to be corrected.
Fixes: #270