Set value of gw to nil for opt121 routes in DHCP #1187
Merged
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omartin2010
force-pushed
the
zerofix
branch
3 times, most recently
from
1c769af to
6ed3d50
Compare
omartin2010
added a commit
to omartin2010/cni-plugins-daemonset
that referenced
this pull request
Jun 9, 2025
omartin2010
added a commit
to omartin2010/cni-plugins-daemonset
that referenced
this pull request
Jun 25, 2025
squeed
approved these changes
Jul 21, 2025
Member
squeed
left a comment
squeed
left a comment
There was a problem hiding this comment.
cute, more fun corners of the DHCP spec.
Can you please squash to a single commit, then force-push? Thanks!
Contributor
Author
|
Done - lmk if this is helpful. |
squeed
approved these changes
Aug 18, 2025
squeed
requested changes
Aug 18, 2025
Member
squeed
left a comment
squeed
left a comment
There was a problem hiding this comment.
Can you rebase and force-push? The PR should have exactly one commit.
…ified with DHCP
Default behavior of the plugin is to try and install routes without
specifying SCOPE which results in not installing certain routes that
do not have a gateway set in the DHCP server response. If the SCOPE is
not set to LINK (in particular for NICs in some cloud environment
that get assigned /32 IPs to them). This change enables routes to be
installed without the router being specified, but sets to SCOPE_LINK.
Signed-off-by: Olivier Martin <[email protected]>
Contributor
Author
|
I think we should be good now! |
squeed
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default behavior of the plugin is to try and install routes without using SRC which prevents routes from being installed in the routing table in (some) cloud environment that assign /32 IPs to NICs. This change enables routes to be installed without this value (and making the scope to be set to SCOPE_LINK. Another way of fixing it would be if the plugin would be refactored to use the SRC object of the struct in github.com/vishvananda/netlink which would require more work and potentially impact other plugins.