Ignore settling with down state since it would never settle #1207
Conversation
mlguerrero12
left a comment
mlguerrero12
left a comment
There was a problem hiding this comment.
ptp tests are failing due to this, could you please check @bn222?
bn222
force-pushed
the
main
branch
4 times, most recently
from
0670505 to
66d52cc
Compare
mlguerrero12
left a comment
mlguerrero12
left a comment
There was a problem hiding this comment.
Discussed internally with @bn222, immediately skipping SettleAddresses if the link state is not up caused adding route failures on the ptp plugin. This usually happens when the address is not present. So, it seems that the link eventually comes up and the address settles. The code relies on the delay added by this function.
For the moment, we decided to add the link status check when the deadline expires (tentative after 5s). When there is no carrier, pod creation will be delayed but it was the previous behavior anyway (returned error was always ignored). This needs to be investigated/fixed in another pr.
Signed-off-by: Balazs Nemeth <[email protected]>
|
@squeed ptal |
3 participants
Ignore settling with down state since the interface would never settle. Literally that: if there is no cable, then this will error out. In the past, it didn't.