Fix undesirable splitting of IPv6 host addresses (#533)

* fix: over splitting for ipv6 addresses

Signed-off-by: linxside <[email protected]>

* test: add test cases for ipv6 oversplitting

Signed-off-by: linxside <[email protected]>

Signed-off-by: linxside <[email protected]>

Author: linxside

plugins/module_utils/podman/podman_container_lib.py

@@ -909,7 +909,7 @@ def diffparam_env(self):
 
     def diffparam_etc_hosts(self):
         if self.info['hostconfig']['extrahosts']:
-            before = dict([i.split(":")
+            before = dict([i.split(":", 1)
                            for i in self.info['hostconfig']['extrahosts']])
         else:
             before = {}

tests/integration/targets/podman_container_idempotency/tasks/idem_all.yml

@@ -242,6 +242,38 @@
       - test18 is not changed
       - test19 is changed
 
+- name: Run container with etc_hosts
+  containers.podman.podman_container:
+    executable: "{{ test_executable | default('podman') }}"
+    image: "{{ idem_image }}"
+    name: idempotency
+    state: present
+    etc_hosts:
+      host1: 127.0.0.1
+      host2: fd00::1
+    command: 1h
+  register: test20
+
+- name: Check info with etc_hosts
+  assert:
+    that: test20 is changed
+
+- name: Run container with etc_hosts again
+  containers.podman.podman_container:
+    executable: "{{ test_executable | default('podman') }}"
+    image: "{{ idem_image }}"
+    name: idempotency
+    state: present
+    etc_hosts:
+      host1: 127.0.0.1
+      host2: fd00::1
+    command: 1h
+  register: test21
+
+- name: Check info with etc_hosts again
+  assert:
+    that: test21 is not changed
+
 - name: Remove test container
   containers.podman.podman_container:
     executable: "{{ test_executable | default('podman') }}"