Skip to content

added podman_prune module #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 31, 2023
Merged

added podman_prune module #538

merged 10 commits into from
Jan 31, 2023

Conversation

@rebtoor
Copy link
Contributor

@rebtoor rebtoor commented Jan 16, 2023 •
edited
Loading

Added podman_prune module, it should fix #352

WIP since i need to add some tests

@rebtoor rebtoor marked this pull request as draft January 16, 2023 14:22
@sshnaidm
Copy link
Member

sshnaidm commented Jan 16, 2023

Please use this skeleton for tests: #531

sshnaidm
sshnaidm requested changes Jan 17, 2023
View reviewed changes
Copy link
Member

@sshnaidm sshnaidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting the review, a few comments inside.

@rebtoor
Copy link
Contributor Author

rebtoor commented Jan 22, 2023 •
edited
Loading

Hi @sshnaidm , I followed your advices on PR and tried to refactor some things inside code. I enabled filters parsing for all modules (in both forms, e.g. "--filter=until=2h" and "--filter=label=Maintainers=Podman Maintainers") and handled the special case of "image" module that can use 2 more flags: "dangling_only" (-a flag in original command) and "external" (--external flag in original command). I'll wait for your review and try to implement some tests.

sshnaidm
sshnaidm requested changes Jan 24, 2023
View reviewed changes
Copy link
Member

@sshnaidm sshnaidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks much better! A few another comment inside, worth to split the function to two.

@rebtoor
created filtersPrepare function
6493cb4 
Signed-off-by: Roberto Alfieri <[email protected]>
@sshnaidm
Copy link
Member

sshnaidm commented Jan 29, 2023

Great, thanks!
Let's create tests now.

@rebtoor rebtoor requested a review from sshnaidm January 29, 2023 22:45
@rebtoor
Copy link
Contributor Author

rebtoor commented Jan 29, 2023

Great, thanks! Let's create tests now.

done! I've also handled output when multiple modules are invoked all at once, it came out during tests... :D

@rebtoor rebtoor changed the title [wip] added podman_prune module added podman_prune module Jan 29, 2023
@rebtoor rebtoor marked this pull request as ready for review January 29, 2023 22:47
sshnaidm
sshnaidm requested changes Jan 30, 2023
View reviewed changes
Copy link
Member

@sshnaidm sshnaidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few comments about tests.
Please rebase your patch on latest.

@rebtoor rebtoor requested a review from sshnaidm January 30, 2023 21:56
@sshnaidm
Copy link
Member

sshnaidm commented Jan 31, 2023

Thanks for your contribution!

@sshnaidm sshnaidm merged commit 7d1d016 into containers:master Jan 31, 2023
@rebtoor rebtoor deleted the podman-prune branch February 1, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sshnaidm sshnaidm sshnaidm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide podman_prune module

2 participants

@rebtoor @sshnaidm