Fix warnings for mismatched_lifetime_syntaxes lint #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust 1.89 introduced this new lint[1], fix the handful of places where it comes up across the repo. [1] https://blog.rust-lang.org/2025/08/07/Rust-1.89.0/#mismatched-lifetime-syntaxes-lint Signed-off-by: John Eckersberg <[email protected]>
Collaborator
Author
|
xref bootc-dev/bootc#1497 |
allisonkarlitskaya
approved these changes
Aug 14, 2025
Collaborator
allisonkarlitskaya
left a comment
allisonkarlitskaya
left a comment
There was a problem hiding this comment.
I read a bit about this new rule and thought it seemed vaguely useful but in practice it's kinda annoying... this is what elided lifetimes is supposed to be about.... I guess I kinda see the point though that it's not obvious that the lifetime is captured here.
Thanks for taking care of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.89 introduced this new lint[1], fix the handful of places where
it comes up across the repo.
[1] https://blog.rust-lang.org/2025/08/07/Rust-1.89.0/#mismatched-lifetime-syntaxes-lint
Signed-off-by: John Eckersberg [email protected]