tests: Ensure necessary dependencies are available #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While most of the runtime dependencies of the test harness were being checked, `socat(1)` had been overlooked. Incorporate a dependency check into the `run-tests` script for it so that the tests don't just mysteriously fail without first indicating that `socat` is required (in the same way as is done with `runc(8)` and others) Signed-off-by: Scott S. McCoy <scott.s.mccoy@acm.org>
ssmccoy
force-pushed
the
ssmccoy/socat-dependency-check
branch
from
0b30856 to
de539b3
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Collaborator
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While most of the runtime dependencies of the test harness were being checked,
socat(1)had been overlooked. Incorporate a dependency check into therun-testsscript for it so that the tests don't just mysteriously fail without first indicating thatsocatis required (in the same way as is done withrunc(8)and others)