Fix FreeBSD 15.0+ SOCK_SEQPACKET message boundary issue#638
Merged
jnovy merged 1 commit intocontainers:mainfrom Feb 24, 2026
Merged
Fix FreeBSD 15.0+ SOCK_SEQPACKET message boundary issue#638jnovy merged 1 commit intocontainers:mainfrom
jnovy merged 1 commit intocontainers:mainfrom
Conversation
On FreeBSD 15.0+, SOCK_SEQPACKET sockets require MSG_EOR flag to mark message boundaries. Using write() without MSG_EOR causes multiple messages to coalesce when reader is slow, leading to frame desynchronization and "output destination cannot be nil" errors. This fix uses send() with MSG_EOR on FreeBSD while keeping the original write_all() behavior on other platforms. Fixes: containers/podman#27918 Signed-off-by: Jindrich Novy <jnovy@redhat.com>
Contributor
|
I believe that Having said this, making the change conditional on FreeBSD is fine (and lower risk). Thanks for working on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On FreeBSD 15.0+, SOCK_SEQPACKET sockets require MSG_EOR flag to mark message boundaries. Using write() without MSG_EOR causes multiple messages to coalesce when reader is slow, leading to frame desynchronization and "output destination cannot be nil" errors.
This fix uses send() with MSG_EOR on FreeBSD while keeping the original write_all() behavior on other platforms.
Fixes: containers/podman#27918