-
Notifications
You must be signed in to change notification settings - Fork 106
Add tmt integration plan #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR introduces a new TMT integration plan by adding a plans/tmt.fmf file, defining the FMF metadata and step configurations for running the test suite under the Packit CI pipeline. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary of ChangesHello @LecrisUT, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new tmt integration plan to streamline the execution of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new tmt plan, plans/tmt.fmf
, to facilitate running tmt's integration tests against this project. The approach of adding a dedicated FMF plan is clean and idiomatic. It is preferable to the alternative of defining tests in .packit.yaml
because it centralizes test definitions within the FMF metadata tree. Regarding your question about podman-next*.repo
, the script in plans/main.fmf
modifies the COPR repository file to set priority=1
. This ensures that packages from the podman-next
repository are given preference during installation, which is necessary for testing the correct package versions in the CI environment. I have one suggestion for the new plan to improve its robustness.
See: - teemtee/tmt#4047 - teemtee/tmt#4026 Signed-off-by: Cristian Le <[email protected]>
bac4f2c
to
f376618
Compare
Tests failed. @containers/packit-build please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dunno why the centos-stream-9 test is failing. Unrelated to the PR.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LecrisUT, lsm5, sourcery-ai[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
32f5b9b
into
containers:main
See:
podman
friends integration plan in relevant repos teemtee/tmt#4047An alternative design is to add the tests in
.packit.yaml
. Let me know which approach would be preferred. I don't quite follow the steps you do withpodman-next*.repo
, maybe we could look into that as well?(should use only one PR where we discuss and test these)
Summary by Sourcery
Add a new FMF plan to integrate tmt test runner into the project, defining the necessary test metadata and execution steps.
New Features:
Tests: