Skip to content

Conversation

LecrisUT
Copy link
Contributor

@LecrisUT LecrisUT commented Sep 22, 2025

See:

An alternative design is to add the tests in .packit.yaml. Let me know which approach would be preferred. I don't quite follow the steps you do with podman-next*.repo, maybe we could look into that as well?

(should use only one PR where we discuss and test these)

Summary by Sourcery

Add a new FMF plan to integrate tmt test runner into the project, defining the necessary test metadata and execution steps.

New Features:

  • Add a new tmt integration plan file (plans/tmt.fmf) to define test execution under tmt

Tests:

  • Introduce a fresh FMF-based test plan for tmt integration

Copy link

sourcery-ai bot commented Sep 22, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR introduces a new TMT integration plan by adding a plans/tmt.fmf file, defining the FMF metadata and step configurations for running the test suite under the Packit CI pipeline.

File-Level Changes

Change Details Files
Add TMT integration FMF plan
  • Created new FMF plan in plans directory
  • Defined plan metadata (name, summary, path)
  • Configured provisioning, execution, and reporting steps for TMT
plans/tmt.fmf

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

Summary of Changes

Hello @LecrisUT, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new tmt integration plan to streamline the execution of tmt's integration tests. By defining this plan, the project aims to incorporate external test definitions, specifically leveraging the /podman plan from the teemtee/tmt repository, to ensure comprehensive testing coverage. The author is also seeking feedback on alternative design approaches and clarification on existing testing steps.

Highlights

  • New tmt Integration Plan: A new tmt.fmf file has been added to define an integration plan for tmt. This plan is configured to import the /podman plan from the teemtee/tmt repository, specifically from the /plans/friends path.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new tmt plan, plans/tmt.fmf, to facilitate running tmt's integration tests against this project. The approach of adding a dedicated FMF plan is clean and idiomatic. It is preferable to the alternative of defining tests in .packit.yaml because it centralizes test definitions within the FMF metadata tree. Regarding your question about podman-next*.repo, the script in plans/main.fmf modifies the COPR repository file to set priority=1. This ensures that packages from the podman-next repository are given preference during installation, which is necessary for testing the correct package versions in the CI environment. I have one suggestion for the new plan to improve its robustness.

Copy link

Tests failed. @containers/packit-build please check.

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dunno why the centos-stream-9 test is failing. Unrelated to the PR.

/lgtm

Copy link

openshift-ci bot commented Sep 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LecrisUT, lsm5, sourcery-ai[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 32f5b9b into containers:main Sep 23, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants