TMT: include podman checkpoint system tests

[lsm5]

podman checkpoint... tests depend on crun as well so they should be included in the TMT system test runs. These are currently failing on podman upstream PRs, for example: 0, 1 and 2.

Summary by Sourcery

Tests:

• Add invocation of the 520-checkpoint.bats script to enable checkpoint tests during TMT runs

[sourcery-ai]

Reviewer's Guide

Extend the Podman TMT system test script to include the checkpoint test by invoking the new '520-checkpoint.bats' case.

File-Level Changes

Change	Details	Files
Integrate checkpoint test into system-test.sh	Add ‘bats -t /usr/share/podman/test/system/520-checkpoint.bats’ invocation	tests/tmt/podman/system-test.sh

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[packit-as-a-service]

TMT tests failed. @containers/packit-build please check.

[giuseppe]

the failure seems to be a regression introduced with e5d2489

@kolyshkin FYI

[giuseppe]

maybe the bisect was not correct, the failure still happens if I revert the patch. Repeating it

[giuseppe]

now I get e0b0158 and indeed there is no error if I revert it

[giuseppe]

do you think we need something like?

diff --git a/src/libcrun/criu.c b/src/libcrun/criu.c
index 2fbcf552..6039be87 100644
--- a/src/libcrun/criu.c
+++ b/src/libcrun/criu.c
@@ -587,9 +587,10 @@ libcrun_container_checkpoint_linux_criu (libcrun_container_status_t *status, lib
           const char *dest_in_root;
 
           dest_in_root = chroot_realpath (rootfs, def->mounts[i]->destination, buf);
-          if (UNLIKELY (dest_in_root == NULL))
-            return crun_make_error (err, errno, "unable to resolve external bind mount `%s` under rootfs", def->mounts[i]->destination);
-          dest_in_root += strlen (rootfs);
+          if (LIKELY (dest_in_root != NULL))
+            dest_in_root += strlen (rootfs);
+          else
+            dest_in_root = def->mounts[i]->destination;
 
           ret = libcriu_wrapper->criu_add_ext_mount (dest_in_root, dest_in_root);
           if (UNLIKELY (ret < 0))
@@ -916,9 +917,10 @@ libcrun_container_restore_linux_criu (libcrun_container_status_t *status, libcru
           const char *dest_in_root;
 
           dest_in_root = chroot_realpath (rootfs, def->mounts[i]->destination, buf);
-          if (UNLIKELY (dest_in_root == NULL))
-            return crun_make_error (err, errno, "unable to resolve external bind mount `%s` under rootfs", def->mounts[i]->destination);
-          dest_in_root += strlen (rootfs);
+          if (LIKELY (dest_in_root != NULL))
+            dest_in_root += strlen (rootfs);
+          else
+            dest_in_root = def->mounts[i]->destination;
 
           ret = libcriu_wrapper->criu_add_ext_mount (dest_in_root, def->mounts[i]->source);
           if (UNLIKELY (ret < 0))

[giuseppe]

proposed patch: #1757

[giuseppe]

@lsm5 are you fine to close this one in favor of #1758?

@kolyshkin FYI

[lsm5]

ah i didn't notice this change was included in #1758. Closing..