Skip to content

WASIp2 component support for wasmtime #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
+362 −50
Draft

WASIp2 component support for wasmtime #1877

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
543cb94
wasmtime: extract running module into function
t4chib4ne Sep 10, 2025
d878baf
wasmtime: Implement basic WASIp2 components support
t4chib4ne Sep 10, 2025
c05cf2e
wasmtime: Check functions after manual loading
t4chib4ne Sep 10, 2025
ce7d656
wasmtime: Add argv to wasm components; Change CMD to ENTRYPOINT in wa…
t4chib4ne Sep 10, 2025
dc2e2e1
wasmtime: have wasip2 inherit env
t4chib4ne Sep 11, 2025
b1c4da5
wasmtime: Fix wat to wasm compiling
t4chib4ne Sep 11, 2025
9a073f6
wasmtime: misc code cleanup
t4chib4ne Sep 12, 2025
e8cbc72
wasmtime: expand reading entrypoint error message
t4chib4ne Sep 19, 2025
741045a
wasmtime: Fix and Add preopen_dir for modules & components
t4chib4ne Sep 11, 2025
cf36a28
wasmtime: properly check wat file extension
t4chib4ne Sep 21, 2025
877ca9a
wasmtime: Add helper for wasm header interpretation
t4chib4ne Sep 21, 2025
d6b9778
wasmtime: branch execution path after wasm header interpretation
t4chib4ne Sep 21, 2025
49f0f42
wasmtime: fix typo in errmsg
t4chib4ne Sep 26, 2025
2170c02
wasmtime: remove e flag from fopen
t4chib4ne Sep 26, 2025
3777fba
wasmtime: harden wasm_interpret_header func
t4chib4ne Oct 1, 2025
4ddd82a
wasmtime: avoid NULL pointer after wasm compilation
t4chib4ne Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/wasm-wasi-example.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ This is from a main function from a wasm module
```Containerfile
FROM scratch
COPY hello.wasm /
CMD ["/hello.wasm"]
ENTRYPOINT ["/hello.wasm"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write it in commit message or here, about why is this change needed ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry forgot to mention it ...

After adding the pass through of argv to the component I wanted to try it out. Upon running podman run mywasm-image:latest arg1 arg2 podman would replace CMD (the wasm binary) with arg1 which of course does not work. Changing to ENTRYPOINT resolves this.

Copy link
Collaborator

@flouthoc flouthoc Sep 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a breaking change. I think adding this message to commit logs can help us revisit this and fix this if needed.

cc @giuseppe

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this to the commit logs should be possible but I don't really see where this is a breaking change? Without the changes of this PR a wasm module runs into the same problem. IIRC this is also the same behavior a non-wasm container would show.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the message in ce7d656 OK?

```
* Build wasm image using buildah
```console
Expand Down
Loading