Skip to content

krun: Rename nitro module to awsnitro#1979

Merged
kolyshkin merged 1 commit intocontainers:mainfrom
tylerfanelli:krun-aws-nitro-rename
Feb 4, 2026
Merged

krun: Rename nitro module to awsnitro#1979
kolyshkin merged 1 commit intocontainers:mainfrom
tylerfanelli:krun-aws-nitro-rename

Conversation

@tylerfanelli
Copy link
Member

@tylerfanelli tylerfanelli commented Feb 2, 2026

nitro is a bit vague. Refer to the module as awsnitro for more clarity.

@gemini-code-assist
Copy link

Summary of Changes

Hello @tylerfanelli, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing code readability and maintainability by standardizing the naming convention for the nitro module within the krun handler. The change clarifies that the module specifically pertains to AWS Nitro Enclaves, making the codebase easier to understand for developers and reducing potential ambiguity.

Highlights

  • Module Renaming: The internal nitro module references have been consistently renamed to awsnitro throughout the krun handler for improved clarity and specificity.
  • Variable and Struct Member Updates: Key variables and struct members such as handle_nitro, ctx_id_nitro, and has_nitro have been updated to their awsnitro counterparts (e.g., handle_awsnitro).
  • Dynamic Library Path Correction: String literals referring to the dynamic library libkrun-nitro.so have been modified to libkrun-awsnitro.so to reflect the new naming convention.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves clarity by renaming nitro to awsnitro. The changes are mostly correct, but I found a few places where the old name is still used. I've added suggestions to complete the renaming for consistency.

@tylerfanelli tylerfanelli force-pushed the krun-aws-nitro-rename branch 2 times, most recently from ce19c3d to 02ed38c Compare February 2, 2026 19:58
@packit-as-a-service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@tylerfanelli tylerfanelli marked this pull request as draft February 2, 2026 21:02
@packit-as-a-service
Copy link

TMT tests failed. @containers/packit-build please check.

@tylerfanelli tylerfanelli marked this pull request as ready for review February 3, 2026 01:49
@tylerfanelli
Copy link
Member Author

cc/ @jakecorrenti

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a very minor nit: a comment in krun.c:394 might need a fixup, for the sake of uniformity.

"nitro" is a bit vague. Refer to the module as "awsnitro" for more
clarity.

Signed-off-by: Tyler Fanelli <tfanelli@redhat.com>
@tylerfanelli tylerfanelli force-pushed the krun-aws-nitro-rename branch from 02ed38c to 463e277 Compare February 4, 2026 04:37
@tylerfanelli
Copy link
Member Author

a very minor nit: a comment in krun.c:394 might need a fixup, for the sake of uniformity.

Thanks for pointing this out, fixed in latest revision.

@kolyshkin kolyshkin merged commit ca0756f into containers:main Feb 4, 2026
40 of 43 checks passed
@tylerfanelli tylerfanelli deleted the krun-aws-nitro-rename branch February 4, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments