utils: do not use errno after success

[eriksjolund]

Closes: #1995

[gemini-code-assist]

Summary of Changes

Hello @eriksjolund, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines error handling within the get_realpath_to_file utility function. It addresses a potential issue where the errno value might be incorrectly captured or used after intermediate successful operations or error cleanup, leading to misleading error reports. By switching to crun_error_wrap, the change ensures that the relevant errno value is correctly associated with the error condition, improving the reliability of error reporting.

Highlights

• Correct errno Usage: Modified error handling in get_realpath_to_file to prevent incorrect usage of errno after potentially successful operations or crun_error_release. The change replaces crun_error_release followed by crun_make_error with a direct call to crun_error_wrap.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/libcrun/utils.c
  • Updated error handling in get_realpath_to_file to use crun_error_wrap for accurate errno capture, preventing its use after success.

Activity

• The pull request addresses and closes issue utils: errno used after success #1995, indicating a resolution to a previously reported problem.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug in the error handling logic of get_realpath_to_file. The previous implementation could have reported an incorrect error because it used the errno global variable after it might have been changed. The new implementation correctly uses crun_error_wrap to add context to the error returned by safe_readlinkat, ensuring the original error information is preserved. The change is clean, correct, and improves the robustness of the code. I have no further comments.

[packit-as-a-service]

TMT tests failed. @containers/packit-build please check.

[giuseppe]

LGTM