Skip to content

[debug] check kernel logs #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kolyshkin wants to merge 1 commit into from
+2 −1
Closed

[debug] check kernel logs #2004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/podman/run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,5 @@ export TMPDIR=/var/tmp

ginkgo --focus='.*' --skip='.*(selinux|notify_socket|systemd|podman run exit 12*|podman run exit code on failure to exec|failed to start|search|trust|inspect|logs|generate|import|mounted rw|inherit host devices|play kube|cgroups=disabled|privileged CapEff|device-cgroup-rule|capabilities|network|pull from docker|--add-host|removes a pod with a container|prune removes a pod with a stopped container|overlay volume flag|prune unused images|podman images filter|image list filter|create --pull|podman ps json format|using journald for container|image tree|--pull|shared layers|child images|cached images|flag with multiple mounts|overlay and used as workdir|image_copy_tmp_dir|Podman run with specified static IPv6 has correct IP|authenticated push|pod create --share-parent|podman kill paused container|login and logout|podman top on privileged container|local registry with authorization|podman update container all options v2|push test|podman pull and run on split imagestore|Podman kube play|uidmapping and gidmapping|push with --add-compression|enforces DiffID matching|push with authorization|artifact).*' \
-vv -tags "seccomp ostree selinux exclude_graphdriver_devicemapper" \
-timeout=50m -cover -flake-attempts 3 -progress -trace -no-color test/e2e/.
-timeout=50m -cover -flake-attempts 3 -progress -trace -no-color test/e2e/. || true
dmesg | grep overlay
Comment on lines +52 to +53
Copy link

@gemini-code-assist gemini-code-assist bot Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Using || true will suppress the exit code of the test suite, causing the CI to pass even if tests fail. This is a critical issue as it can hide genuine test failures. To ensure kernel logs are captured on failure without suppressing the test result, you should capture the exit code of the test command and then exit with it after printing the logs.

Suggested change
-timeout=50m -cover -flake-attempts 3 -progress -trace -no-color test/e2e/. || true
dmesg | grep overlay
-timeout=50m -cover -flake-attempts 3 -progress -trace -no-color test/e2e/.
result=$?
dmesg | grep overlay
exit $result