Losen the dependency on go-connections/tlsconfig #2926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 7, 2025
As of go-connections 0.6.0, there is no difference between "server" and "client" configuration; so, take this opportunity to switch from "server" defaults in client contexts, which were used for an unknown reason. Also, don't use the whole tlsconfig.ClientDefault(), to _slightly_ move into the direction of using the Go built-in defaults, and to get a _bit_ closer to getting out of the business of managing TLS policy. The TLS configuration in docker/daemon continues to use the full tlsconfig.Client(), because that's (to an extent) consistent with the defaults of github.com/docker/docker/client. Should not change behavior (but the update from go-connections 0.5.0 to 0.6.0 did change the list of accepted TLS 1.2 cipher suites). Signed-off-by: Miloslav Trmač <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of
go-connections0.6.0, there is no difference between "server" and "client" configuration; so, take this opportunity to switch from "server" defaults in client contexts, which were used for an unknown reason.Also, don't use the whole
tlsconfig.ClientDefault(), to slightly move into the direction of using the Go built-in defaults, and to get a bit closer to getting out of the business of managing TLS policy.The TLS configuration in
docker/daemoncontinues to use the fulltlsconfig.Client(), because that's (to an extent) consistent with the defaults ofgithub.com/docker/docker/client.Should not change behavior (but the update from
go-connections0.5.0 to 0.6.0 did change the list of accepted TLS 1.2 cipher suites).