Introduce enabled/disabled tool list in configuration file #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
|
Currently implementing your review suggestions. Will ping you there when ready for a last review |
manusa
reviewed
Jul 1, 2025
pkg/config/config.go
Outdated
| SSEBaseURL string `toml:"sse_base_url,omitempty"` | ||
| KubeConfig string `toml:"kubeconfig,omitempty"` | ||
| ListOutput string `toml:"list_output,omitempty"` | ||
| ReadOnly bool `toml:"read_only,omitempty"` |
Member
There was a problem hiding this comment.
I think it would be good to move the description comment here since to clarify its purpose:
// When true, expose only tools annotated with readOnlyHint=true
Same for DisableDestructive
Member
Author
There was a problem hiding this comment.
Good point. I'll add these comments.
manusa
reviewed
Jul 1, 2025
Member
manusa
left a comment
manusa
left a comment
There was a problem hiding this comment.
LGTM, however, I think I'd rename allowed_tools to enabled_tools and denied_tools to disabled_tools.
Member
Author
enabled/disabled is more descriptive than allowed/denied. I'll update with that. |
ardaguclu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #156
This PR introduces enabled/disabled tool list in the configuration file.
Users will be able to add enabled and disabled tools in the configuration file. e.g.
This list will be applied to the given profile (full is the default);
This PR partially fixes #151
In a follow up PR, I'll add validations to prevent duplicate entries in both enable and disabled list.