Removal of rigid binding to kubeconfig env var and skip some tests in OCP #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… OCP Relying on KUBECONFIG env variable causes issues in cases where env var is statically set by the environments. So that default namespace is modified to something different than default with less permissions. That causes failures of the tests. Additionally, all namespaces tests are broken in CI environments that the given temporary namespace can't access to query the all namespaces in the cluster. This commit skips these tests. Signed-off-by: Arda Güçlü <[email protected]>
ardaguclu
force-pushed
the
fix-ocp-unit-test-failures
branch
from
5f80a54 to
0f0946f
Compare
Member
Author
|
/cc @manusa |
Member
Author
|
Fixes #273 |
Member
Author
|
@manusa has found a better solution. Closing this one |
This was referenced Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relying on KUBECONFIG env variable causes issues in cases where env var is statically set by the environments. So that default namespace is modified to something different than default with less permissions. That causes failures of the tests.
Additionally, all namespaces tests are broken in CI environments that the given temporary namespace can't access to query the all namespaces in the cluster.
This PR skips these tests.
As proven in here openshift#24, after the changes in here,
testpasses.