refactor: move provider initialization into factory #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calum Murray <[email protected]>
manusa
approved these changes
Oct 9, 2025
Comment on lines
+15
to
+25
| var providerFactories = make(map[string]ProviderFactory) | ||
|
|
||
| // RegisterProvider registers a provider factory for a given strategy name. | ||
| // This should be called from init() functions in provider implementation files. | ||
| // Panics if a provider is already registered for the given strategy. | ||
| func RegisterProvider(strategy string, factory ProviderFactory) { | ||
| if _, exists := providerFactories[strategy]; exists { | ||
| panic(fmt.Sprintf("provider already registered for strategy '%s'", strategy)) | ||
| } | ||
| providerFactories[strategy] = factory | ||
| } |
There was a problem hiding this comment.
❤️ This is exactly what I was thinking of
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables adding other
ManagerProviderimplementations more easily in downstream repos such as theopenshift-mcp-server, without introducing any git conflicts between the twoRelates/follows up to #348
Relates to #83