Skip to content

fix(nodes): nodes_log query and tailLines arguments #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2025
Merged

fix(nodes): nodes_log query and tailLines arguments #409

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43c1762
Fix the node log query
ngopalak-redhat Oct 27, 2025
14fa2b3
Fix the node log query
ngopalak-redhat Oct 27, 2025
5553a4e
fix(nodes): nodes_log query and tailLines arguments
manusa Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/kubernetes/accesscontrol_clientset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,11 @@ func (a *AccessControlClientset) NodesLogs(ctx context.Context, name, logPath st
return nil, fmt.Errorf("failed to get node %s: %w", name, err)
}

url := []string{"api", "v1", "nodes", name, "proxy", "logs", logPath}
url := []string{"api", "v1", "nodes", name, "proxy", "logs"}
return a.delegate.CoreV1().RESTClient().
Get().
AbsPath(url...), nil
AbsPath(url...).
Param("query", logPath), nil
}

func (a *AccessControlClientset) Pods(namespace string) (corev1.PodInterface, error) {
Expand Down