devices/x86_64: add cmos legacy device #419
Open
+219
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ram size info to ArchMemoryInfo, since we're going to need for the CMOS legacy device. Signed-off-by: Sergio Lopez <[email protected]>
slp
requested review from
MatiasVara,
jakecorrenti,
mtjhrc and
tylerfanelli
as code owners
slp
force-pushed
the
add-cmos-device
branch
3 times, most recently
from
0ed164d to
866d449
Compare
u-boot uses a legacy CMOS device to obtain the ram size, so do a minimal implementation ourselves. Signed-off-by: Sergio Lopez <[email protected]>
We need to inject the firmware region just before the last one. Fix it to do it properly. Signed-off-by: Sergio Lopez <[email protected]>
slp
force-pushed
the
add-cmos-device
branch
from
866d449 to
0f7eb91
Compare
MatiasVara
reviewed
Oct 1, 2025
|
IIUC this legacy device is always enabled in x86-64, am I right? may we have a way to decide to use it or not? |
Yes, so far we've tried to always use the same set of legacy devices, only moving around the virtio ones. I think it's better to always have the cmos device (which is very small and innocuous) present. |
MatiasVara
reviewed
Oct 7, 2025
|
@MatiasVara do you need more changes to this PR? |
I have nothing to add. It LGTM. I did not try it though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
u-boot uses a legacy CMOS device to obtain the ram size, so do a minimal implementation ourselves.
While there, also fix a bug in the recently introduced firmware support code.