topology-aware: prevent choosing node without enough capacity #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A node with exactly enough capacity should win a node without enough capacity. Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Collaborator
|
I think this should only be allowed if there are not containers assigned to the shared subset of CPUs in the pool. Otherwise we might use up the shared cpuset fully and try to reassign burstable containers in the pool to the empty cpuset which will then fail. |
Collaborator
|
This is now fixed by PR #601. Closing this in favor of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A node with exactly enough capacity should win a node without enough capacity.