Allow skipping TLS verification while pulling images #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germag
reviewed
Feb 18, 2025
cmd/run.go
Outdated
| @@ -52,6 +53,7 @@ func init() { | |||
| runCmd.Flags().BoolVar(&vmConfig.Quiet, "quiet", false, "Suppress output from bootc disk creation and VM boot console") | |||
| runCmd.Flags().StringVar(&diskImageConfigInstance.RootSizeMax, "root-size-max", "", "Maximum size of root filesystem in bytes; optionally accepts M, G, T suffixes") | |||
| runCmd.Flags().StringVar(&diskImageConfigInstance.DiskSize, "disk-size", "", "Allocate a disk image of this size in bytes; optionally accepts M, G, T suffixes") | |||
| runCmd.Flags().BoolVar(&vmConfig.SkipTLSVerify, "insecure", false, "Skip TLS verification while pulling the image") | |||
There was a problem hiding this comment.
Just to be coherent with podman, I think it's better to use the same options: —tls-verify=false|true
There was a problem hiding this comment.
Yep, makes sense. Changed to --tls-verify
|
Hi, thanks for doing this As a general rule we want a descriptive commit message, also it's required the signed-of-by |
|
Closed this and created a new PR with cleaned up commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87