Skip to content

Added support to parse extra hosts#1381

Merged
p12tic merged 1 commit intocontainers:mainfrom
Athishpranav2003:extra-hosts
Feb 26, 2026
Merged

Added support to parse extra hosts#1381
p12tic merged 1 commit intocontainers:mainfrom
Athishpranav2003:extra-hosts

Conversation

@Athishpranav2003
Copy link
Contributor

@Athishpranav2003 Athishpranav2003 commented Jan 24, 2026

This PR addresses this missing feature.

Fixes #1366

@Athishpranav2003
Copy link
Contributor Author

The code was tested manually and all information is available in the issue itself.

@p12tic
Copy link
Collaborator

p12tic commented Feb 10, 2026

Looks good, but needs a release note and an integration test. I think adding example.internal:127.0.0.1 should work for ping - the test can then check if ping output is expected.

Copy link
Collaborator

@p12tic p12tic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as "requested changes" for myself.

@Athishpranav2003
Copy link
Contributor Author

@p12tic do u need me to write the test as well?

@p12tic
Copy link
Collaborator

p12tic commented Feb 23, 2026

@p12tic do u need me to write the test as well?

Yes. There are a lot of existing integration tests that you can look into for ideas.

@Athishpranav2003
Copy link
Contributor Author

@p12tic ping is a privileged process, hence it needs more permissions to run --cap-add=NET_RAW. I am falling back to curl itself

@Athishpranav2003
Copy link
Contributor Author

@p12tic done added integration testing

@Athishpranav2003 Athishpranav2003 force-pushed the extra-hosts branch 2 times, most recently from 4c1262d to 10a9b40 Compare February 25, 2026 13:25
Copy link
Collaborator

@p12tic p12tic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A release note still missing (see newsfragments directory). Also the branch currently contains two commits, these should be squashed.

added support to parse extra hosts

added newsfragments

Signed-off-by: Athishpranav2003 <athishanna@gmail.com>
@Athishpranav2003
Copy link
Contributor Author

@p12tic done,
not sure abt the PR check fail tho

@p12tic p12tic merged commit 9a82af2 into containers:main Feb 26, 2026
42 of 43 checks passed
@Athishpranav2003
Copy link
Contributor Author

@p12tic when is the next release planned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

extra_hosts doesnt add the entry to podman build command

2 participants