Added support to parse extra hosts#1381
Conversation
|
The code was tested manually and all information is available in the issue itself. |
|
Looks good, but needs a release note and an integration test. I think adding example.internal:127.0.0.1 should work for ping - the test can then check if ping output is expected. |
p12tic
left a comment
There was a problem hiding this comment.
Marking as "requested changes" for myself.
|
@p12tic do u need me to write the test as well? |
Yes. There are a lot of existing integration tests that you can look into for ideas. |
|
@p12tic ping is a privileged process, hence it needs more permissions to run |
|
@p12tic done added integration testing |
4c1262d to
10a9b40
Compare
tests/integration/extra_hosts/test_podman_compose_extra_hosts.py
Outdated
Show resolved
Hide resolved
added support to parse extra hosts added newsfragments Signed-off-by: Athishpranav2003 <athishanna@gmail.com>
d028351 to
b85fa9e
Compare
|
@p12tic done, |
|
@p12tic when is the next release planned? |
This PR addresses this missing feature.
Fixes #1366