Skip to content

Fix top-level name interpolation#1416

Merged
p12tic merged 2 commits intocontainers:mainfrom
Ramdek:main
Mar 15, 2026
Merged

Fix top-level name interpolation#1416
p12tic merged 2 commits intocontainers:mainfrom
Ramdek:main

Conversation

@Ramdek
Copy link
Contributor

@Ramdek Ramdek commented Mar 13, 2026

This fixes the top-level name attribute interpolation not happening.

See #1319.

@Ramdek
Copy link
Contributor Author

Ramdek commented Mar 14, 2026

Sorry for the noise.
Would you prefer gpg signed commits with my pseudo as sign-off or non gpg commits with real name as sign-off ?

Copy link
Collaborator

@p12tic p12tic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add a release note (see newsfragments/README.txt)

@p12tic
Copy link
Collaborator

p12tic commented Mar 15, 2026

Would you prefer gpg signed commits with my pseudo as sign-off or non gpg commits with real name as sign-off ?

Best would be real name sign-off . GPG signing is not necessary

Ramdek added 2 commits March 15, 2026 13:04
fixes #1319

Signed-off-by: Jonathan Sling <slingjonathan@gmail.com>
Refs #1319

Signed-off-by: Jonathan Sling <slingjonathan@gmail.com>
@Ramdek
Copy link
Contributor Author

Ramdek commented Mar 15, 2026

One check fails because of docker pull rate limit.

@p12tic p12tic merged commit fa24cad into containers:main Mar 15, 2026
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants