Skip to content

fix: implement symbolic links #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: implement symbolic links #1184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 53 additions & 14 deletions packages/backend/src/managers/gitManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
* SPDX-License-Identifier: Apache-2.0
***********************************************************************/

import { window } from '@podman-desktop/api';
import fs, { statSync, existsSync, mkdirSync, rmSync } from 'node:fs';
import git from 'isomorphic-git';
import { env, window } from '@podman-desktop/api';
import fs, { existsSync, mkdirSync, type NoParamCallback, rmSync, statSync } from 'node:fs';
import git, { type CallbackFsClient } from 'isomorphic-git';
import http from 'isomorphic-git/http/node';

export interface GitCloneInfo {
Expand All @@ -27,11 +27,50 @@ export interface GitCloneInfo {
targetDirectory: string;
}

function getFs(): CallbackFsClient {
if (env.isWindows) {
return {
chmod: fs.chmod,
lstat: fs.lstat,
mkdir: fs.mkdir,
readFile: fs.readFile,
readdir: fs.readdir,
readlink: fs.readlink,
rmdir: fs.rmdir,
stat: fs.stat,
symlink: (
target: fs.PathLike,
path: fs.PathLike,
type_: fs.symlink.Type | undefined,
callback: fs.NoParamCallback,
) => {
if (!callback) {
callback = type_ as unknown as NoParamCallback;
type_ = undefined;
}
fs.symlink(target, path, type_, err => {
if (err) {
fs.writeFile(path, target.toString(), { mode: 0o0444 }, err => {
callback(err);
});
} else {
// eslint-disable-next-line no-null/no-null
callback(null);
}
});
},
unlink: fs.unlink,
writeFile: fs.writeFile,
};
}
return fs;
}

export class GitManager {
async cloneRepository(gitCloneInfo: GitCloneInfo) {
// clone repo
await git.clone({
fs,
fs: getFs(),
http,
dir: gitCloneInfo.targetDirectory,
url: gitCloneInfo.repository,
Expand Down Expand Up @@ -78,7 +117,7 @@ export class GitManager {
clean: boolean;
}> {
const status = await git.statusMatrix({
fs,
fs: getFs(),
dir: directory,
});

Expand Down Expand Up @@ -106,12 +145,12 @@ export class GitManager {
}

async getCurrentCommit(directory: string): Promise<string> {
return git.resolveRef({ fs, dir: directory, ref: 'HEAD' });
return git.resolveRef({ fs: getFs(), dir: directory, ref: 'HEAD' });
}

async pull(directory: string): Promise<void> {
return git.pull({
fs,
fs: getFs(),
http,
dir: directory,
});
Expand Down Expand Up @@ -170,7 +209,7 @@ export class GitManager {
): Promise<{ ok?: boolean; updatable?: boolean; error?: string }> {
// fetch updates
await git.fetch({
fs,
fs: getFs(),
http,
dir: directory,
});
Expand All @@ -186,7 +225,7 @@ export class GitManager {
}

const branch = await git.currentBranch({
fs,
fs: getFs(),
dir: directory,
});

Expand Down Expand Up @@ -240,12 +279,12 @@ export class GitManager {

async getTrackingBranch(directory: string, branch: string): Promise<string | undefined> {
const mergeRef = await git.getConfig({
fs,
fs: getFs(),
dir: directory,
path: `branch.${branch}.merge`,
});
const remote = await git.getConfig({
fs,
fs: getFs(),
dir: directory,
path: `branch.${branch}.remote`,
});
Expand All @@ -257,7 +296,7 @@ export class GitManager {

const remoteCommits = (
await git.log({
fs,
fs: getFs(),
dir,
ref: remoteBranch,
})
Expand All @@ -266,7 +305,7 @@ export class GitManager {
.sort();
const localCommits = (
await git.log({
fs,
fs: getFs(),
dir,
ref: localBranch,
})
Expand Down Expand Up @@ -302,7 +341,7 @@ export class GitManager {
async getTagCommitId(directory: string, tagName: string): Promise<string | undefined> {
try {
return await git.resolveRef({
fs,
fs: getFs(),
dir: directory,
ref: tagName,
});
Expand Down