feat(GPUManager): check nvidia container toolkit capabilities#1825
Draft
axel7083 wants to merge 1 commit intocontainers:mainfrom
Draft
feat(GPUManager): check nvidia container toolkit capabilities#1825axel7083 wants to merge 1 commit intocontainers:mainfrom
axel7083 wants to merge 1 commit intocontainers:mainfrom
Conversation
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Contributor
|
I dont have a NVIDIA GPU 😢 to test this |
jeffmaury
reviewed
Oct 2, 2024
Collaborator
jeffmaury
left a comment
There was a problem hiding this comment.
Linux code seems to be based on local podman. Is there a way to check ? What is user is using Podman machine ?
|
|
||
| // check nvidia-ctk version | ||
| const { version } = await this.getNvidiaContainerToolKitVersion(connection); | ||
| console.log('nvidia-ctk version', version); |
Contributor
Author
There was a problem hiding this comment.
Yeah, in a follow-up PR I want to use telemetry, but I want to be a separate issue as discussion will probably happen :)
Contributor
Author
@jeffmaury if the |
Contributor
Author
|
Moving to draft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add some utility function to the
GPUManagerto check ifnvidia-ctkis installed on the machine or native host (linux) for nvidia cards.Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Fixes #1824
Requied for #1591
Part of #1708
How to test this PR?
Manually
You can check manually by adding the following code to the studio.ts