Skip to content

Conversation

gastoner
Copy link
Contributor

@gastoner gastoner commented Apr 23, 2025

What does this PR do?

Migrates model select component to svelte5 syntax

Screenshot / video of UI

What issues does this PR fix or reference?

Required for #2893

How to test this PR?

Pr check

@gastoner gastoner requested review from benoitf, jeffmaury and a team as code owners April 23, 2025 08:04
@axel7083
Copy link
Contributor

Please update the PR title & description, we don't know what component is migrated

@gastoner gastoner changed the title refactor(svelte5): migrated component to svelte5 refactor(svelte5): migrated model select component to svelte5 Apr 23, 2025
Signed-off-by: Evzen Gasta <[email protected]>
@gastoner
Copy link
Contributor Author

@axel7083 @benoitf fixed

Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise LGTM

(Can't test ATM, but seems okay 👍)

@gastoner gastoner requested a review from benoitf April 24, 2025 05:05
Copy link
Collaborator

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastoner gastoner merged commit 11855c3 into containers:main Apr 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants