changed a short name of image to full name#373
Merged
rhatdan merged 1 commit intocontainers:mainfrom Mar 11, 2025
Merged
Conversation
Before downloading the image, only full name work. Signed-off-by: Sangyong Gwak <imyaman@netscape.net>
Member
|
I don't necessarily object to this PR but even the name you provided is not full. It should have a :tag to be full imho. Also, for me, podman pull alpine works because a short name is available. What distribution are you hitting this with? |
Contributor
Author
|
FreeBSD 14.2, amd64. When I ran podman pull alpine, I got the following error: Adding |
Member
|
how about amending your PR with an "If this happens to you ... " |
Member
|
Changes LGTM, will wait to see if there's further discussion/changes inbound. |
Luap99
approved these changes
Mar 5, 2025
Member
Luap99
left a comment
Luap99
left a comment
There was a problem hiding this comment.
LGTM, using full names overall seems like a very good idea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before downloading the image, only full name work.