Skip to content

e2e: skip pre-checkpoint tests on aarch64 #26234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

e2e: skip pre-checkpoint tests on aarch64 #26234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/e2e/checkpoint_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,6 +977,9 @@ var _ = Describe("Podman checkpoint", func() {
})

It("podman checkpoint container with --pre-checkpoint", func() {
if podmanTest.Host.Arch == "arm64" {
Skip("skip on arm64/aarch64, checkpoint-restore/criu GH issue #2676")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could as well put the full URL here instead so users don't have to manually look it up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even better yes. I'll do a followup.

btw, long term it'd be even better to implement Adrian's suggestion of checking for criu's supported feature set on the arch and skipping based on that.

}
SkipIfContainerized("FIXME: #24230 - no longer works in container testing")
if !criu.MemTrack() {
Skip("system (architecture/kernel/CRIU) does not support memory tracking")
Expand Down Expand Up @@ -1010,6 +1013,9 @@ var _ = Describe("Podman checkpoint", func() {
})

It("podman checkpoint container with --pre-checkpoint and export (migration)", func() {
if podmanTest.Host.Arch == "arm64" {
Skip("skip on arm64/aarch64, checkpoint-restore/criu GH issue #2676")
}
SkipIfContainerized("FIXME: #24230 - no longer works in container testing")
SkipIfRemote("--import-previous is not yet supported on the remote client")
if !criu.MemTrack() {
Expand Down