Skip to content

Conversation

marrusl
Copy link
Contributor

@marrusl marrusl commented Aug 7, 2025

Does this PR introduce a user-facing change?

no

None

@mheon
Copy link
Member

mheon commented Aug 7, 2025

Lint is angry about an extra newline at end of file

Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI passes.

@mheon
Copy link
Member

mheon commented Aug 11, 2025

Recommend you squash down to one commit, that will probably make the linter happy

Removing last line again.

Co-authored-by: Jan Rodák <[email protected]>
Signed-off-by: Mark Russell <[email protected]>
@marrusl
Copy link
Contributor Author

marrusl commented Aug 11, 2025

Recommend you squash down to one commit, that will probably make the linter happy

I would have, but I clicked off on @Honny1's diff before I saw that and for some reason it passed this time

@mheon
Copy link
Member

mheon commented Aug 12, 2025

/approve
LGTM

Copy link
Contributor

openshift-ci bot commented Aug 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, marrusl, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2025
@baude
Copy link
Member

baude commented Aug 21, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit e38e664 into containers:main Aug 21, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants