-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New: initial ADOPTERS.md file. #26775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mark Russell <[email protected]>
Lint is angry about an extra newline at end of file |
Signed-off-by: Mark Russell <[email protected]>
Signed-off-by: Mark Russell <[email protected]>
Signed-off-by: Mark Russell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CI passes.
Recommend you squash down to one commit, that will probably make the linter happy |
Removing last line again. Co-authored-by: Jan Rodák <[email protected]> Signed-off-by: Mark Russell <[email protected]>
I would have, but I clicked off on @Honny1's diff before I saw that and for some reason it passed this time |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Honny1, marrusl, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Does this PR introduce a user-facing change?
no