-
Notifications
You must be signed in to change notification settings - Fork 2.8k
WSL machine tests: increase kernel boot timeout #27235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, you need to rebase once #27234 is merged to unblock CI.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: l0rd, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
Ok it still flaked, I added the info to microsoft/WSL#13301 (comment) See the comment there with how the tests overwrite USERPROFILE so I wonder if this setting was actually read or must written as part of the test suite setup to take effect. |
d83e149
to
3734c33
Compare
I suspect that the problem was that we created the |
I am not sure how that works with the USERPROFILE override in the tests as well though
Could be that we actually have to create the file in the BeforeEach() where we setup the temp home as well as I don't know how wsl reads the file. Anyhow seems like test passed this time but this is no solid indicator though its general flakiness, we should keep pressing rerun a couple of times https://cirrus-ci.com/task/5074728311848960 to see if we can it to fail still |
Ok it still failed after the third rerun https://cirrus-ci.com/task/6196427237359616 |
Mind adding the config write into the go test code where we update USERPROFILE to see if that changes things? |
This is to avoid CI/CD flakes and is based on this analysis of the WSL flakes logs: microsoft/WSL#13301 (comment) Signed-off-by: Mario Loriedo <[email protected]>
I have updated the |
Tests are still barking, but the code LGTM |
This is to avoid CI/CD flakes and is based on this analysis of the WSL flakes logs:
microsoft/WSL#13301 (comment)
Does this PR introduce a user-facing change?