Pod Quadlet can configure podman pod stop --time #27250
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nimdrak The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nimdrak
changed the title
|
I think you will also have to document this in https://github.com/containers/podman/blob/main/docs/source/markdown/podman-systemd.unit.5.md |
|
@jankaluza Thanks. I missed the point. I'll do that soon. |
nimdrak
force-pushed
the
27120
branch
2 times, most recently
from
f93e444 to
007d3b8
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
pkg/systemd/quadlet/quadlet.go
Outdated
| execStop := createBasePodmanCommand(podUnit, PodGroup) | ||
| execStop.add("pod", "stop") | ||
| stopTimeout := "10" | ||
| if value, ok := podUnit.Lookup(PodGroup, "StopTimeout"); ok { |
There was a problem hiding this comment.
| if value, ok := podUnit.Lookup(PodGroup, "StopTimeout"); ok { | |
| if value, ok := podUnit.Lookup(PodGroup, KeyStopTimeout); ok { |
There was a problem hiding this comment.
Thank you so much, I reflected it !
|
|
||
| This is equivalent to the Podman `--shm-size` option and generally has the form `number[unit]` | ||
|
|
||
| ### `StopTimeOut` |
There was a problem hiding this comment.
| ### `StopTimeOut` | |
| ### `StopTimeout` |
There was a problem hiding this comment.
Thanks, I reflected it!
nimdrak
force-pushed
the
27120
branch
2 times, most recently
from
e168bec to
7b2c32b
Compare
Signed-off-by: ByoungUk Lee <[email protected]>
Signed-off-by: ByoungUk Lee <[email protected]>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
You have some trailing whitespace in podman-systemd.unit.5.md |
Fixed #27120
Does this PR introduce a user-facing change?