Skip to content

[WIP] Enhance error logs when it failed to relabel due to permission #27610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] Enhance error logs when it failed to relabel due to permission #27610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions libpod/container_internal_common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3156,6 +3156,10 @@ func (c *Container) relabel(src, mountLabel string, shared bool) error {
logrus.Debugf("Labeling not supported on %q", src)
return nil
}
if errors.Is(err, unix.EPERM) {
currentUID := os.Getuid()
return fmt.Errorf("labeling failed on %q: likely due to a file owned by another user (current user: uid %d) or insufficient permissions: %w", src, currentUID, err)
}
return err
}

Expand Down