Add export and unexport commands for desktop and CLI integration #1682
Conversation
silverhadch
force-pushed
the
kde-kontainer
branch
from
211b7d9 to
ddf29ce
Compare
|
Build failed. ❌ unit-test FAILURE in 5m 27s |
|
Build failed. ❌ unit-test FAILURE in 4m 51s |
silverhadch
force-pushed
the
kde-kontainer
branch
2 times, most recently
from
1c0c994 to
4486a70
Compare
|
Build failed. ❌ unit-test FAILURE in 5m 06s |
|
Build failed. ❌ unit-test FAILURE in 5m 40s |
|
TODO: Use runCommand rather then calling toolbox binary from toolbox thats ugly. |
|
Build failed. ❌ unit-test FAILURE in 5m 51s |
|
Build failed. ✔️ unit-test SUCCESS in 5m 58s |
silverhadch
force-pushed
the
kde-kontainer
branch
from
82a1dd0 to
01ee80f
Compare
|
@debarshiray |
|
Build failed. ✔️ unit-test SUCCESS in 2m 18s |
|
@debarshiray |
There was a problem hiding this comment.
Thanks for working on this, @silverhadch !
I have historically avoided adding this feature to Toolbx and stopped at adding the run command because I was apprehensive of muddying our Flatpak story - that Flatpak is for shipping graphical desktop applications, and Toolbx is for software development and troubleshooting the host OS.
A few days ago, I spoke to @alexlarsson about this again, because we had a similar discussion when the run command was added. He gave his blessing, so we are free to go, as far as I am concerned. :)
I am leaving for a two week vacation tomorrow, which meant that I had a ton of miscellaneous things to wrap up before leaving, and kept failing to get to this pull request. My apologies for that.
However, I didn't want to leave you hanging for another two weeks. So, while I didn't get the chance to try out and test your PR, I wanted to say that we will move it forward once I am back, and then into a release.
|
Build succeeded. ✔️ unit-test SUCCESS in 2m 19s |
|
Build failed. ✔️ unit-test SUCCESS in 2m 10s |
|
Build failed. ✔️ unit-test SUCCESS in 2m 15s |
|
Build failed. ✔️ unit-test SUCCESS in 2m 42s |
|
Gofmt is screaming at my Code. But i am also on vacation so screw you! |
|
Build succeeded. ✔️ unit-test SUCCESS in 3m 42s |
🚀 |
Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
toolbox Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
We forgot to create the .local/bin directory in $HOME when calling exportBinary unlike exportApplication, where we make sure we create .local/share/applications. Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
… subcommand and use a custom runCommand to supress stdout to the host Console. Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
Signed-off-by: Hadi Chokr <[email protected]>
silverhadch
force-pushed
the
kde-kontainer
branch
from
6b3e6f2 to
d2f2592
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 2m 06s |
|
When will this be merged? This is a very useful feature that will greatly improve user experience on immutable distros :) |
|
I am currently busy working on an immutable Distro for KDE (KDE Linux) tho this is in my backlog. I'll take care of it in December when i am on Vacation from work. |
3 participants
This PR introduces two new subcommands:
exportandunexport.toolbox exportallows exporting GUI apps (.desktopfiles via--app) or CLI binaries (--bin) from a container to the host.toolbox unexportallows removing those exported apps/binaries. It also supports--allto remove all exports for a container.Also adds an additional runCommand Function that captures stdout of the run Command needed by the export.go.
Additionally some small refactor.
Examples:
toolbox export --app gimp --container Arch
→ Exports gimp to ~/.local/share/applications/gimp-Arch.desktop
toolbox export --bin nvim --container Arch
→ Exports nvim to ~/.local/bin/nvim
toolbox unexport --app gimp --container Arch
→ Removes the exported .desktop file
toolbox unexport --all --container Arch
→ Removes all exported items for container Arch
Fixes #1018