Open
Conversation
discordier
requested changes
Apr 13, 2021
Member
discordier
left a comment
There was a problem hiding this comment.
Aside from the changes requested above, I am not sure if expanding the Environment is the best solution but I lack an alternative approach.
Maybe @dmolineus or @stefanheimes have some thoughts on this?
The flat config registry is there to map a data definition that has a parent definition as a flat. In this registry, no filtering or similar is applied by the parent.
3133d6a to
5419b2a
Compare
Member
|
We discussed that we rather add an additional interface to the base config class which allows to fetch the config better. |
Member
|
Change the merge from target => release/2.2.0 to master since master is the 2.2.x version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.