Fix back end route controller example #225

aschempp · 2020-01-15T18:03:06Z

I think the menu listener is invalid as well. @sheeep can you check if the code works?

docs/dev/guides/backend-routes.md

fritzmg

Imho we should advocate the "Action Domain Responder" (ADR) pattern, especially when using __invoke.

fritzmg · 2020-01-16T09:33:57Z

docs/dev/guides/backend-routes.md

-     * @Route("/my-backend-route", name="app.backend-route")
-     * @Template("my_backend_route.html.twig")
+     * @Route("", name="app.backend-route")
     */


This whole annotation block is not needed anymore, is it?

This still needs to be removed.

docs/dev/guides/backend-routes.md

fritzmg · 2020-01-16T09:35:04Z

docs/dev/guides/backend-routes.md

- *     "_backend_module" = "my-modules"
- * })
+ * @Route("/contao//my-backend-route",
+ *     name="app.backend-route" 


Suggested change

* name="app.backend-route"

* name=App\Action\BackendAction::class,

I have never seen a route with a class name, not sure this works (and is best practice?)

Yes this works and is much more useful as you can then simply write

$this->router->generate(BackendAction::class)

in PHP.

There is a trailing comma missing after name="" which leads to AnnotationException.php line 42: [Syntax Error] Expected Doctrine\Common\Annotations\DocLexer::T_CLOSE_PARENTHESIS, got 'defaults' error

docs/dev/guides/backend-routes.md

Co-Authored-By: Fritz Michael Gschwantner <[email protected]>

fritzmg · 2020-01-16T10:31:21Z

docs/dev/guides/backend-routes.md

- *     "_backend_module" = "my-modules"
- * })
+ * @Route("/contao/my-backend-route",
+ *     name="app.backend-route" 


Suggested change

* name="app.backend-route"

* name=App\Controller\BackendController::class

aschempp · 2020-01-16T10:44:31Z

is there any recommendation from Symfony on how to name routes?
/cc @contao/developers

richardhj · 2020-02-05T11:35:38Z

docs/dev/guides/backend-routes.md

- *     "_backend_module" = "my-modules"
- * })
+ * @Route("/contao//my-backend-route",
+ *     name="app.backend-route" 


There is a trailing comma missing after name="" which leads to AnnotationException.php line 42: [Syntax Error] Expected Doctrine\Common\Annotations\DocLexer::T_CLOSE_PARENTHESIS, got 'defaults' error

richardhj · 2020-02-05T11:40:42Z

Currently getting error
The controller for URI "/contao/my-backend-route" is not callable. Controller "App\Controller\BackendController" cannot be fetched from the container because it is private. Did you forget to tag the service with "controller.service_arguments"?

We should add the following to the services.yml (in this document).

  App\Controller\:
    resource: ../src/Controller/*
    tags:
      - name: controller.service_arguments

WDYT @aschempp?

aschempp · 2020-02-07T06:22:35Z

@richardhj that should not be necessary if your class extends the AbstractController and you have autoconfig enabled?

fritzmg · 2020-02-07T09:12:21Z

I personally prefer to not extend from the AbstractController and instead making the service simply public.

But since the example does extend, no services.yml change should be necessary (if autowire is enabled).

fritzmg · 2020-02-07T09:13:06Z

docs/dev/guides/backend-routes.md

-     * @Route("/my-backend-route", name="app.backend-route")
-     * @Template("my_backend_route.html.twig")
+     * @Route("", name="app.backend-route")
     */


This still needs to be removed.

bytehead · 2020-02-07T09:15:39Z

Why do you not prefer to extend from the AbstractController?

fritzmg · 2020-02-07T09:20:04Z

Why do you not prefer to extend from the AbstractController?

I usually don't actually need any features from AbstractController.

fritzmg · 2020-03-04T15:28:41Z

Thank you @aschempp

Fix back end route controller example

11f424f

aschempp requested review from sheeep and netzarbeiter January 15, 2020 18:03

aschempp requested a review from fritzmg as a code owner January 15, 2020 18:03

aschempp added the Bug label Jan 15, 2020

github-actions bot added the Developer Documentation label Jan 15, 2020

fiedsch reviewed Jan 16, 2020

View reviewed changes

docs/dev/guides/backend-routes.md Outdated Show resolved Hide resolved

fritzmg mentioned this pull request Jan 16, 2020

Update back end routes guide #218

Closed

2 tasks

fritzmg requested changes Jan 16, 2020

View reviewed changes

Apply suggestions from code review

77a32c0

Co-Authored-By: Fritz Michael Gschwantner <[email protected]>

fritzmg reviewed Jan 16, 2020

View reviewed changes

richardhj suggested changes Feb 5, 2020

View reviewed changes

fritzmg requested changes Feb 7, 2020

View reviewed changes

change route name and remove superfluous annotation

3be88c0

fritzmg approved these changes Mar 4, 2020

View reviewed changes

fritzmg merged commit b74e349 into master Mar 4, 2020

fritzmg deleted the bugfix/backend-routes branch March 4, 2020 15:28

	* name="app.backend-route"
	* name=App\Action\BackendAction::class,

	* name="app.backend-route"
	* name=App\Controller\BackendController::class

Uh oh!

Fix back end route controller example #225

Fix back end route controller example #225

Conversation

aschempp commented Jan 15, 2020

Uh oh!

Uh oh!

fritzmg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fritzmg Jan 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aschempp commented Jan 16, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

richardhj commented Feb 5, 2020

Uh oh!

aschempp commented Feb 7, 2020

Uh oh!

fritzmg commented Feb 7, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bytehead commented Feb 7, 2020

Uh oh!

fritzmg commented Feb 7, 2020

Uh oh!

fritzmg commented Mar 4, 2020

Uh oh!

Uh oh!

fritzmg Jan 16, 2020 •

edited

Loading