fix: wire up content pane registry for PTY dirty notifications#59
Merged
fix: wire up content pane registry for PTY dirty notifications#59
Conversation
The content pane registry callback (set_register_content_pane_fn) was never connected at startup, so the PTY event loop could never find terminal content panes to notify. Terminals only updated via GPUI's entity-tracking mechanism, which doesn't work reliably through cached views — causing 200-1300ms frame stalls on macOS. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_register_content_pane_fn) was never connected at startupcached()views, causing 200–1300ms frame stallsChanges
Wire up
set_register_content_pane_fninmain.rsto insert into the existingcontent_pane_registry(). This is a 5-line fix — the registry and callback infrastructure already existed but were never connected.Test plan
cached()view optimization (from previous commit) still works