fix: reduce token TTL to 14 days with 3-day refresh threshold#89
Open
fix: reduce token TTL to 14 days with 3-day refresh threshold#89
Conversation
The previous 30-day TTL with 14-day refresh threshold left a narrow window for refresh and kept stolen tokens valid for too long. New values: 14-day TTL with 3-day refresh — active clients refresh early and live indefinitely, inactive clients survive up to 2 weeks. Supersedes #80 which proposed 24h TTL (too aggressive for paired desktops that may be unused for a week). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manager.rs(said "20 hours", now says "3 days")Supersedes #80 — that PR proposed 24h TTL which would break the use case of paired desktops left unused for a week. 14 days is the sweet spot: short enough to limit exposure of stolen tokens, long enough to survive extended inactivity.
Web client (
App.tsx) uses dynamic75% of TTLscheduling — no changes needed there.Files changed
src/remote/auth.rs—TOKEN_TTL_SECScrates/okena-core/src/client/types.rs—TOKEN_REFRESH_AGE_SECScrates/okena-remote-client/src/manager.rs— doc comment fixTest plan
cargo test— 32 tests pass🤖 Generated with Claude Code