Skip to content

Conversation

redaranj
Copy link
Contributor

Changes in this pull request

This PR brings the iOS repo structurally in-line with the c2pa-android repo. We rely on Xcode wherever possible and turn the Makefile into a wrapper around Xcode build commands as we did with Gradle/Android Studio in the other repo.

Tests are moved out of the Example app into a shared test scheme and the Example app now demos real functionality.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • All applicable changes have been documented
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment

Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 65.17277% with 1018 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.05%. Comparing base (dd33b8c) to head (21971bd).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
TestShared/Sources/HardwareSigningTests.swift 12.23% 337 Missing ⚠️
TestShared/Sources/ReaderTests.swift 67.76% 98 Missing ⚠️
TestShared/Sources/ComprehensiveTests.swift 77.44% 97 Missing ⚠️
Library/Sources/SecureEnclaveSigner.swift 0.00% 90 Missing ⚠️
TestShared/Sources/StreamTests.swift 74.89% 58 Missing ⚠️
Library/Sources/KeychainSigner.swift 0.00% 54 Missing ⚠️
Library/Sources/WebServiceSigner.swift 75.53% 46 Missing ⚠️
TestShared/Sources/TestUtilities.swift 43.20% 46 Missing ⚠️
TestShared/Sources/SigningTests.swift 84.75% 41 Missing ⚠️
Library/Sources/Signer.swift 59.37% 39 Missing ⚠️
... and 7 more

❗ There is a different number of reports uploaded between BASE (dd33b8c) and HEAD (21971bd). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (dd33b8c) HEAD (21971bd)
4 0
Additional details and impacted files
@@             Coverage Diff              @@
##              main      #15       +/-   ##
============================================
- Coverage   100.00%   59.05%   -40.95%     
============================================
  Files            1       20       +19     
  Lines          104     3226     +3122     
============================================
+ Hits           104     1905     +1801     
- Misses           0     1321     +1321     
Flag Coverage Δ
unittests 59.05% <65.17%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scouten-adobe scouten-adobe changed the title Chore: Reorganize repo chore: Reorganize repo Sep 18, 2025

// Server base URL for the C2PA signing server, needs to start
// with 'https:/$()/' to avoid being treated as a comment
SIGNING_SERVER_URL = https:/$()/air.tiger-agama.ts.net:8081
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it OK that this URL is public?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scouten-adobe Good catch. It's gone now.

@scouten-adobe
Copy link
Contributor

scouten-adobe commented Sep 25, 2025

Withdrawing this PR. I don't see meaningful perf gains in any of these variations.

So sorry, that comment was intended for a completely different window.

@redaranj redaranj merged commit d014e0c into contentauth:main Sep 29, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants