-
Notifications
You must be signed in to change notification settings - Fork 2
chore: Reorganize repo #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
============================================
- Coverage 100.00% 59.05% -40.95%
============================================
Files 1 20 +19
Lines 104 3226 +3122
============================================
+ Hits 104 1905 +1801
- Misses 0 1321 +1321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Configurations/Base.xcconfig
Outdated
|
||
// Server base URL for the C2PA signing server, needs to start | ||
// with 'https:/$()/' to avoid being treated as a comment | ||
SIGNING_SERVER_URL = https:/$()/air.tiger-agama.ts.net:8081 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it OK that this URL is public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scouten-adobe Good catch. It's gone now.
So sorry, that comment was intended for a completely different window. |
Changes in this pull request
This PR brings the iOS repo structurally in-line with the c2pa-android repo. We rely on Xcode wherever possible and turn the Makefile into a wrapper around Xcode build commands as we did with Gradle/Android Studio in the other repo.
Tests are moved out of the Example app into a shared test scheme and the Example app now demos real functionality.
Types of changes
Checklist
TO DO
items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment