Skip to content

making L2 keyboard focusable #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

making L2 keyboard focusable #79

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bd1ba18
making L2 keyboard focusable
Feb 14, 2023
f718190
change log
Feb 14, 2023
fd01cc5
popover
Mar 4, 2023
d340b67
create l2 component
Mar 8, 2023
745764e
changes
Mar 9, 2023
5f52609
finished adding L2
Apr 10, 2023
7f3abad
finished l2 button work on indicator
Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/c2pa-wc/CAI-3405_2023-02-14-16-41.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "c2pa-wc",
"comment": "making L2 keyboard focusable",
"type": "patch"
}
],
"packageName": "c2pa-wc"
}
2 changes: 1 addition & 1 deletion packages/c2pa-wc/src/components/Popover/Popover.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ export class Popover extends LitElement {
<slot name="content"></slot>
${this.arrow ? html`<div id="arrow"></div>` : null}
</div>
<div id="trigger">
<div id="trigger" tabindex="0">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be better to let consumers decide how to implement a11y rather than forcing the decision on them here.

I suggest doing this on the verify side by passing focusin:focusout as a trigger type to cai-popover and adding tabindex="0" to <cai-indicator>.

<div class="hidden-layer"></div>
<slot name="trigger"></slot>
</div>
Expand Down