-
Notifications
You must be signed in to change notification settings - Fork 23
feat: Update c2pa.py #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: Update c2pa.py #105
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
37bc58a
fix: Library loader
tmathern 13fb182
fix: Refactor
tmathern af7ca87
fix: Loader
tmathern 434efcd
fix: Clean up tests
tmathern 9b9d35f
fix: Some renaming going on (#106)
tmathern 4f766dd
fix: Simplify build (#107)
tmathern cc2369f
ci: Merge commit
tmathern fb4ad6d
chore: rename 1 function
tmathern 2d106b2
fix: Rename errors camel case
tmathern 93e4190
fix: Add debug logs to the loading of libs
tmathern 32cbb81
fix: Format download logs
tmathern c494633
fix: Platform checks, download only one platform
tmathern f470a8e
fix: Load library, one test failure
tmathern File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| include src/c2pa/libs/*.dylib | ||
| include src/c2pa/libs/*.dll | ||
| include src/c2pa/libs/*.so | ||
| include src/c2pa/libs/*.so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # Build dependencies | ||
| wheel==0.41.2 # For building wheels | ||
| setuptools==68.0.0 # For building packages | ||
|
|
||
| # Testing dependencies | ||
| pytest==7.4.0 | ||
|
|
||
| # for downloading the library artifacts | ||
| requests>=2.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we can run this from the root of the repo. I used this instead of
build.pybecausebuild.pyseems broken, whereas that one works. Let me know ifbuild.pywas meant to stay or not - but then it likely needs debugging.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did work on build.py to get it functional, but I can merge that in.