Skip to content

Conversation

@tmathern
Copy link
Collaborator

@tmathern tmathern commented Aug 20, 2025

  • Update to support v0.59.1 version of native libs (will enable PDF manifest reading support) and make needed changes accordingly
  • Some stream handling changes (to make sure in-memory validations pass)
  • Formatting to make most code analysis tools more happy

Additional fixes/changes:

  • Refactor ingredient handling from stream
  • Fix some typings
  • Remove tests that did the same as other tests (in threading tests)

Closes:

@tmathern tmathern self-assigned this Aug 20, 2025
This was referenced Aug 20, 2025
@tmathern
Copy link
Collaborator Author

Also reuse code from #142 already, as on macOS we're already using universal libraries.

@tmathern tmathern requested review from crandmck, dyro and gpeacock August 25, 2025 17:48
@tmathern tmathern requested review from ok-nick and removed request for crandmck August 25, 2025 18:08
@tmathern tmathern requested a review from gpeacock August 25, 2025 21:52
Copy link
Contributor

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on the condition that you either remove the softwareAgent fields or replace them with structures.

@tmathern
Copy link
Collaborator Author

Approved on the condition that you either remove the softwareAgent fields or replace them with structures.

Done: I removed them. Let's keep it simple for the examples and tests.

@tmathern tmathern merged commit ad877cb into main Aug 25, 2025
19 checks passed
@tmathern tmathern deleted the mathern/pdf-test branch August 25, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants