Change return type of signing method to bytes #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with static analysis since the function actually returns bytes now
Collaborator
|
Good catch! Thanks for the contribution. |
Collaborator
|
@rokclimb15 Would you mind signing the Adobe CLA (look at the workflow checks, it's the failing one), so we can merge this contribution? Thank you! |
Collaborator
|
(I'll approve and merge the PR once the CLA is signed and all tests pass). |
tmathern
approved these changes
Aug 22, 2025
Collaborator
tmathern
left a comment
tmathern
left a comment
There was a problem hiding this comment.
This will be included in next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with static analysis since the function actually returns bytes now