Skip to content

feat: add settings structs to the public API #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

feat: add settings structs to the public API #1447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
550319b
feat: add settings structs to public API
ok-nick Sep 24, 2025
2d710cb
feat: add json schemas for settings structs
ok-nick Sep 24, 2025
10aed0e
docs: document all settings structs and fields
ok-nick Sep 25, 2025
992ec27
docs: document settings modules
ok-nick Sep 25, 2025
17927f5
docs: finishing documenting settings structs and fix doc lints
ok-nick Sep 25, 2025
be43767
docs: document main settings struct fields
ok-nick Sep 25, 2025
f752fb5
fix: naming and old field tests
ok-nick Sep 25, 2025
40591e7
fix: add back trust.verify_trust_list
ok-nick Sep 25, 2025
a89476f
fix: doc verify setting warnings, private icon resource, single integ…
ok-nick Sep 29, 2025
b3e6cb4
fix: specify claim generator info operating system as enum
ok-nick Sep 29, 2025
aee4a00
fix: example settings files
ok-nick Sep 29, 2025
2ae744f
docs: clarify `verify_trust` doesn't include `verify_timestamp_trust`
ok-nick Sep 29, 2025
3cfa107
docs: improve certificate status fetch/override docs
ok-nick Sep 29, 2025
3b2cb72
docs: clarify ocsp_fetch and certificate status settings
ok-nick Oct 7, 2025
9fb4585
fix: private `OcspFetchScope`
ok-nick Oct 8, 2025
4efca84
docs: clarify `remote_manifest_fetch` docs
ok-nick Oct 8, 2025
62f34dd
docs: clarify thumbnail settings
ok-nick Oct 8, 2025
7d93444
fix: use LLVM triples as claim generator OS convention
ok-nick Oct 8, 2025
2791e68
Merge branch 'main' into ok-nick/pub-settings
gpeacock Oct 11, 2025
585c9bc
docs: remove hidden attribute for pub(crate) fields and clean up
ok-nick Oct 13, 2025
f3d9ff4
fix: add c2pa-kp-claimSigning OID to trusted EKUs
ok-nick Oct 13, 2025
c2dd7f8
Merge branch 'main' of github.com:contentauth/c2pa-rs into ok-nick/pu…
ok-nick Oct 15, 2025
d5816e6
Merge branch 'main' of github.com:contentauth/c2pa-rs into ok-nick/pu…
ok-nick Oct 16, 2025
2e221f4
fix: don't serde skip builder.actions, only schemars skip
ok-nick Oct 16, 2025
9d80172
fix: feature flag schemars(skip)
ok-nick Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions cli/tests/fixtures/trust/cawg_sign_settings.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
# c2pa-rs Configuration File

# Version information.
version_major = 1
version_minor = 0
version = 1

# Trust settings for certificate validation.
# [trust]
Expand Down Expand Up @@ -220,13 +219,13 @@ xPd7wFhjRZHfuWb2cs63xjAGjQ==
"""
# String to trust configuration.
trust_config = """
//id-kp-emailProtection
//id-kp-emailProtection
1.3.6.1.5.5.7.3.4
//id-kp-documentSigning
//id-kp-documentSigning
1.3.6.1.5.5.7.3.36
//id-kp-timeStamping
//id-kp-timeStamping
1.3.6.1.5.5.7.3.8
//id-kp-OCSPSigning
//id-kp-OCSPSigning
1.3.6.1.5.5.7.3.9
// MS C2PA Signing
1.3.6.1.4.1.311.76.59.1.9
Expand Down Expand Up @@ -418,8 +417,8 @@ name = "c2pa-rs testing"
version = "1.0.0"
# The operating system the claim generator is running on.
#operating_system.name = "macOS"
# Or if the name isn't specified, it can be inferred automatically.
operating_system.infer = true
# Or specify "auto" to infer the operating system automatically.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we fetching OCSP responses for every certificate as a default!

certificate_status_fetch = "all"
certificate_status_should_override = true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, that's interesting. @scouten-adobe any input on this?

operating_system = "auto"
# Arbitrary fields can also be defined.
#
# By default, the SDK adds a field "org.cai.c2pa_rs" with the value
Expand Down
14 changes: 8 additions & 6 deletions cli/tests/fixtures/trust/cawg_test_settings.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,18 @@ trusted = true

[trust]
trust_config = """
//id-kp-emailProtection
//id-kp-emailProtection
1.3.6.1.5.5.7.3.4
//id-kp-documentSigning
//id-kp-documentSigning
1.3.6.1.5.5.7.3.36
//id-kp-timeStamping
//id-kp-timeStamping
1.3.6.1.5.5.7.3.8
//id-kp-OCSPSigning
//id-kp-OCSPSigning
1.3.6.1.5.5.7.3.9
// MS C2PA Signing
1.3.6.1.4.1.311.76.59.1.9
// c2pa-kp-claimSigning
1.3.6.1.4.1.62558.2.1
"""
trust_anchors = """
-----BEGIN CERTIFICATE-----
Expand Down Expand Up @@ -227,9 +229,9 @@ xPd7wFhjRZHfuWb2cs63xjAGjQ==

[cawg_trust]
trust_config = """
//id-kp-emailProtection
//id-kp-emailProtection
1.3.6.1.5.5.7.3.4
//id-kp-documentSigning
//id-kp-documentSigning
1.3.6.1.5.5.7.3.36
"""
trust_anchors = """
Expand Down
8 changes: 3 additions & 5 deletions sdk/examples/c2pa.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
# c2pa-rs Configuration File

# Version information.
version_major = 1
version_minor = 0
version = 1

# # Trust settings for certificate validation.
# [trust]
Expand Down Expand Up @@ -66,9 +65,8 @@ name = "My Service"
# A human readable string of the product's version.
version = "1.0.0"
# The operating system the claim generator is running on.
operating_system.name = "macOS"
# Or if the name isn't specified, it can be inferred automatically.
operating_system.infer = true
# Or specify "auto" to infer the operating system automatically.
operating_system = "macOS"
# Arbitrary fields can also be defined.
#
# By default, the SDK adds a field "org.cai.c2pa_rs" with the value
Expand Down
Loading