-
Notifications
You must be signed in to change notification settings - Fork 99
feat: impl ReaderBuilder
#1465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ok-nick
wants to merge
111
commits into
main
Choose a base branch
from
ok-nick/settings-builders
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: impl ReaderBuilder
#1465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nch 'origin' into ok-nick/settings-builders
Still needs docs and tests but marking as ready for further discussion. |
…ttings-not-thread-local
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a
ReaderBuilder
for constructing aReader
with settings and various other options. We may want to consider introducing a similar pattern to theBuilder
, although that may take additional design consideration.For some background, we need methods of passing in
Settings
to aReader
orBuilder
that are instance-local, rather than thread-local. There are numerous reasons why this is needed that have taken place in other discussions. The reason we decided to introduce aReaderBuilder
is because it's impractical and arguably unidiomatic to create or change ~9 of theReader
constructors. It also offers much more flexibility and enables many new permutations of constructing aReader
.Note that this is only an investigation, we may consider going the other route of providing an
Asset
struct to encapsulate assets, allowing us to cache a map of the files internals so we don't need to parse it multiple times.Blocked by: