Skip to content

fix: Empty actions array should be allowed for v1 claim compatibility [CAI-9573] #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: Empty actions array should be allowed for v1 claim compatibility [CAI-9573] #1477

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
88b7901
feat: add fmt Display for Builder
gpeacock Oct 4, 2025
676ca2a
fix: allow empty actions array for v1 claims
gpeacock Oct 4, 2025
83e879c
chore: remove accidental changes
gpeacock Oct 4, 2025
0a2cd10
Merge branch 'main' into gpeacock/v1_empty_actions
gpeacock Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions sdk/src/claim.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2001,6 +2001,13 @@ impl Claim {
)?;
}

// Skip further checks for v1 claims if not in strict validation mode
if claim.version() == 1 {
if let Ok(false) = get_settings_value::<bool>("verify.strict_v1_validation") {
return Ok(()); // no further checks for v1 claims
}
}

// 1. make sure every action has an actions array that is not empty
if let Some(bad_assertion) = all_actions.iter().find(|a| {
if let Ok(actions) = Actions::from_assertion(a.assertion()) {
Expand Down