Skip to content

Conversation

@cdmurph32
Copy link
Collaborator

Changes in this pull request

Using the C2PA SDK in work-stealing thread scheduling runtimes (like tokio), will lead to inconsistent settings application with thread_local settings

Run Reader and Builder unit tests single threaded. An alternate strategy would be to allow local settings to be passed as an argument to Reader and Builder.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 28.57143% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.41%. Comparing base (0302f47) to head (7032ffa).

Files with missing lines Patch % Lines
sdk/src/settings/mod.rs 28.57% 25 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (0302f47) and HEAD (7032ffa). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (0302f47) HEAD (7032ffa)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1529       +/-   ##
===========================================
- Coverage   78.03%   28.41%   -49.63%     
===========================================
  Files         162      144       -18     
  Lines       40266    27795    -12471     
===========================================
- Hits        31423     7898    -23525     
- Misses       8843    19897    +11054     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 27, 2025

CodSpeed Performance Report

Merging #1529 will not alter performance

Comparing global_settings_redux (7032ffa) with main (0302f47)

Summary

✅ 16 untouched
⏩ 2 skipped1

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants